feat: upgrade to support Vue 3 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Vue 3 is now required to use this plugin.
|
Looks good, I don't have a specific way of writing tests so feel free to create another PR for it. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal to upgrade the stack and the components to Vue 3. I also upgraded the few dependencies it has and adapted the configuration accordingly.
The only question I have is: what do you want to do regarding tests? It currently depends on vue-test-utils and has one spec but there’s no test runner configured. Would you like me to install Jest and add a suite or should I clean those up for now as they won’t work with Vue 3 anyway?
fixes #113