Skip to content

fix: comply to width & height attributes #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix: comply to width & height attributes #119

merged 1 commit into from
Jan 27, 2021

Conversation

LeBenLeBen
Copy link
Collaborator

fix #46

fix #46

BREAKING CHANGE:

`width` and `height` attributes are now applied as-is to the `svg` element, if you want the previous, responsive behavior, use only the new `viewBox` prop instead.

Before: `width="200" height="100"`
After: `viewBox="0 0 200 100"`
@LeBenLeBen LeBenLeBen changed the base branch from master to dev January 27, 2021 09:42
@LeBenLeBen LeBenLeBen merged commit 8e844cf into dev Jan 27, 2021
@LeBenLeBen LeBenLeBen deleted the issue/46 branch January 27, 2021 09:42
@egoist
Copy link
Owner

egoist commented Jan 27, 2021

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong height
2 participants