Skip to content

* Update implementation & spec to be 3.0 compatible #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2021

Conversation

PikachuEXE
Copy link
Collaborator

Mainly around the breaking behaviour change about keyword arguments

@PikachuEXE PikachuEXE linked an issue Apr 20, 2021 that may be closed by this pull request
@PikachuEXE PikachuEXE marked this pull request as ready for review April 21, 2021 08:37
@PikachuEXE
Copy link
Collaborator Author

@egonSchiele
Please merge this and release 0.17 once you think it's ready

@egonSchiele egonSchiele merged commit 4caf4fd into master May 7, 2021
@egonSchiele
Copy link
Owner

nice change 👍

@egonSchiele
Copy link
Owner

0.17 published

@PikachuEXE PikachuEXE deleted the fix/3.0-compatible branch May 27, 2021 03:54
@PikachuEXE
Copy link
Collaborator Author

Just realized 0.17 is released instead of 0.17.0
Oops

@mscwilson
Copy link

Hello, we had some trouble with keyword arguments for our gem (Snowplow Ruby tracker). Unfortunately, we've had to remove Contracts completely.

Because we need to support Ruby 2 and 3, it's not possible to select a Contracts version in the gemspec that will work for both. It's alright locally with a conditional statement in the gemspec, but that doesn't work with RubyGems.

Just wanted to let you know in case this affects others too.

@PikachuEXE
Copy link
Collaborator Author

Yup I wish I can support both.
But it's too difficult for me.

Feel free to try to make it compatible with both 2.7 & 3.x.
I think that's this gem is supporting (especially for Ruby 2 > 3 transition).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test fails on ruby 3.0 due to keyword argument separation
3 participants