Handle overflow in proof size#210
Merged
mwillsey merged 3 commits intoegraphs-good:mainfrom Oct 25, 2022
Merged
Conversation
Member
|
This looks good! It seems like this may be a case where you should prefer |
Member
Author
|
Fixed! Ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the overflow in proof size estimates by capping them at
usize::MAX.I considered using floating-point, but it's harder to reason about floating-point numbers and they also do not implement
Ordwhich is a problem for the heap implementation.Another thing to consider would be using a bignum, but I'm not sure if it matters.