Skip to content

Major versions upgrade #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

fredjn
Copy link
Member

@fredjn fredjn commented Sep 26, 2023

Applicable Issues

fixes: #65
fixes: #64
fixes: #40

Description of the Change

  • Major Python and dependency version(s) overhaul. Moving away from python 3.6 has been long overdue, and these changes bump us all the way to 3.11, which is the latest and greatest.
  • Add docker compose file to help ease the setup of a working dev environment, which include
    • RabbitMQ
    • MongoDB
    • GraphQL API
    • Storage backend

Alternate Designs

Moving everything to Poetry might have been even better, but I figured it should be handled in a separate PR.

Benefits

Running EOL versions of python and friends is bad, mkay!

Possible Drawbacks

Since it is quite a big version bump there might be runtime and intermittent bugs ahead, but I don't see how it can warrant running EOL versions of software.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Fredrik Fristedt <[email protected]>

Upgraded python version to 3.11.5, and also lifting dependencies to
resonably modern versions. Dropped Flask-grapql as it was only a
wrapper for grapql-server.

Change-Id: I151ccd444393d5fcbd15f7ca9b45573db6b27f91
@fredjn fredjn requested a review from a team as a code owner September 26, 2023 11:32
@fredjn fredjn requested review from t-persson and magnusbaeck and removed request for a team September 26, 2023 11:32
Copy link
Member

@magnusbaeck magnusbaeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the PR connected to all three issues in the PR description, you need one "Fixes " prefix per issue, i.e.

Fixes #1
Fixes #2
Fixes #3

Fredrik Fristedt added 3 commits September 28, 2023 11:17
Add docker compose file(s), with dependency services defined, to aid
in setting up a proper development environment.

Change-Id: I20564878ba52b4215edb7eb945b37852912af59f
Bump version(s) of python as well as test environment dependencies

Change-Id: I50632d04d65559e5d24a308e1218b89636b18122
Change-Id: I966bb752dbc9c30e5b3ba30581efa9be2b062672
@fredjn fredjn force-pushed the major-versions-upgrade branch from 9ea0996 to 97b386f Compare September 28, 2023 09:18
@fredjn fredjn merged commit 5d6c61d into eiffel-community:master Sep 29, 2023
@fredjn fredjn deleted the major-versions-upgrade branch September 29, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants