Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the CI GitHub Actions workflow to reduce duplication, centralize configuration, and extract misc dependency setup into a reusable composite action.
Changes:
- Adds workflow-level defaults (permissions + shared env like
PRIMARY_JDK/ EA JDK metadata) and introduces job timeouts. - Reworks checkout/JDK/Gradle setup steps across jobs for consistency, and factors out
miscdependency installation into a composite action. - Updates the
miscdependency installation to use apt/pip caching via the new composite action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Restructures CI jobs, introduces shared env/permissions, and uses the new setup-misc composite action for misc runs. |
.github/actions/setup-misc/action.yml |
New composite action to install and cache dependencies needed by the misc test script. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:174
- Same issue here:
fetch-depth: ${{ matrix.script == 'misc' && 0 || 1 }}can never yield0, somiscwon't get full history inotherjdks. Use a truthy true-branch value (e.g., string '0') or separate checkout steps guarded byif:.
- name: Check out sources
uses: actions/checkout@v6
with:
fetch-depth: ${{ matrix.script == 'misc' && 0 || 1 }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Default minimal permissions for all jobs; individual steps may opt-in to more. | ||
| permissions: | ||
| contents: read |
Comment on lines
+20
to
+25
| env: | ||
| PRIMARY_JDK: "21" | ||
| USE_BAZEL_VERSION: "9.1.0" | ||
| # JDK 27 early-access build; bump when a new EA build is published. | ||
| JDK_EA_MAJOR: "27" | ||
| JDK_EA_BUILD: "22" |
| using: composite | ||
| steps: | ||
| - name: Cache and install apt packages | ||
| uses: awalsh128/cache-apt-pkgs-action@v1 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
As suggested by Copilot
Member
Author
|
#1728 suggested adding |
Member
Author
|
|
Member
Author
|
@copilot the misc job is still failing. In a separate pull request against this PR, fix the problem |
wmdietl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started with Claude, then fixes from Copilot, then Claude had to fix those. Seems to work now.