Skip to content

Fix Clusters Fail to Create Private Endpoint and Identity Provider #8411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

amdonov
Copy link
Contributor

@amdonov amdonov commented Jun 6, 2025

Description

Include a timeout setting when associating an identity provider as part of cluster creation. This allows the task to complete before subsequent tasks attempt to modify the cluster. Addresses issue #8410

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Member

@naclonts naclonts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks great! thanks for submitting the fix here.

A couple of housekeeping requests:

  1. Could you update the Pull Request Subject line to describe the issue/fix?
  • The subject line is what will appear in the Release Notes, so a sentence like your Issue subject would be helpful (e.g. Fix Clusters Fail to Create with Private Endpoint and Identity Provider)
  1. Could you include a mention of the Issue number in the PR Description field?
  • Doing so will automatically link the PR to the Issue, and GitHub will auto-close the issue once the PR is merged

@amdonov amdonov changed the title fixes eksctl-io/eksctl#8410 Fix Clusters Fail to Create Private Endpoint and Identity Provider Jun 6, 2025
Copy link
Member

@naclonts naclonts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🚀

@naclonts naclonts merged commit c66077a into eksctl-io:main Jun 6, 2025
11 of 13 checks passed
yehielnetapp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Jun 9, 2025
…ksctl-io#8411)

Include a timeout setting when associating an identity provider as part of cluster creation. This allows the task to complete before subsequent tasks attempt to modify the cluster. Addresses issue eksctl-io#8410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants