Master

.github/ISSUE_TEMPLATE.md

@@ -1,31 +1,9 @@
-Read first: <https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md>
+<--
 
-### Describe the issue
+Do not open issue here.
 
+The official issue tracker for uBlock Origin is at:
 
-### One or more specific URLs where the issue occurs
+https://github.com/uBlockOrigin/uBlock-issues/issues
 
-[URL(s) for issue on a specific site are **mandatory**]
-
-### Screenshot in which the issue can be seen
-
-[Screenshot(s) for visual issues are **mandatory**]
-
-### Steps for anyone to reproduce the issue
-
-1. Be as detailed as possible:
-1. Because we are not looking over your shoulder and
-1. Keep in mind: Nobody can read your mind.
-
-### Your settings
-
-[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]
-
-- Browser/version: 
-- uBlock Origin version: 
-
-##### Your filter lists
-
-[Example: "Default filter lists + FRA", or "Default filter lists minus uBlock -- Badware risks"]
-
-##### Your custom filters (if any)
+-->

.github/workflows/main.yml

@@ -0,0 +1,70 @@
+name: GitHub CI
+
+on:
+  create:
+    branches: master
+
+# I used the following project as template to get started:
+# https://github.com/dessant/search-by-image/blob/master/.github/workflows/ci.yml
+
+jobs:
+  build:
+    name: Build packages
+    runs-on: ubuntu-latest
+    if: startsWith(github.ref, 'refs/tags/')
+    steps:
+      - name: Clone repository
+        uses: actions/checkout@v2
+        with:
+          persist-credentials: false
+      - name: Clone uAssets
+        run: |
+          pushd ..
+          git clone --depth 1 https://github.com/uBlockOrigin/uAssets.git
+          popd
+      # https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html
+      - name: Get release information
+        id: release_info
+        run: |
+          echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
+      - name: Create GitHub release
+        id: create_release
+        uses: actions/create-release@v1
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
+        with:
+          tag_name: ${{ steps.release_info.outputs.VERSION }}
+          release_name: ${{ steps.release_info.outputs.VERSION }}
+          prerelease: true
+      - name: Build all packages
+        run: |
+          tools/make-chromium.sh ${{ steps.release_info.outputs.VERSION }}
+          tools/make-firefox.sh ${{ steps.release_info.outputs.VERSION }}
+          tools/make-thunderbird.sh ${{ steps.release_info.outputs.VERSION }}
+      - name: Upload Chromium package
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: dist/build/uBlock0_${{ steps.release_info.outputs.VERSION }}.chromium.zip
+          asset_name: uBlock0_${{ steps.release_info.outputs.VERSION }}.chromium.zip
+          asset_content_type: application/octet-stream
+      - name: Upload Firefox package
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: dist/build/uBlock0_${{ steps.release_info.outputs.VERSION }}.firefox.xpi
+          asset_name: uBlock0_${{ steps.release_info.outputs.VERSION }}.firefox.xpi
+          asset_content_type: application/octet-stream
+      - name: Upload Thunderbird package
+        uses: actions/upload-release-asset@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          upload_url: ${{ steps.create_release.outputs.upload_url }}
+          asset_path: dist/build/uBlock0_${{ steps.release_info.outputs.VERSION }}.thunderbird.xpi
+          asset_name: uBlock0_${{ steps.release_info.outputs.VERSION }}.thunderbird.xpi
+          asset_content_type: application/octet-stream

.jshintrc

@@ -2,13 +2,15 @@
 	"browser": true,
 	"devel": true,
 	"eqeqeq": true,
-	"esnext": true,
+	"esversion": 8,
 	"globals": {
-		"chrome": false,
-		"Components": false, // global variable in Firefox
+		"browser": false,    // global variable in Firefox, Edge
+		"chrome": false,     // global variable in Chromium, Chrome, Opera
+		"log": false,
 		"safari": false,
 		"self": false,
 		"vAPI": false,
+		"webext": false,
 		"µBlock": false
 	},
 	"laxbreak": true,
@@ -18,6 +20,5 @@
 	"sub": true,
 	"undef": true,
 	"unused": true,
-	"validthis": true,
-	"-W058": true // suppress "Missing '()' invoking a constructor" message
+	"validthis": true
 }

CONTRIBUTING.md

@@ -1,81 +1,5 @@
 # Submitting issues
 
-For **support/discussions**, there is [Mozilla Discourse](https://discourse.mozilla-community.org/t/support-ublock-origin/6746).
+Submit on <https://github.com/uBlockOrigin/uBlock-issues/issues>.
 
-For **filter-related issues**, report on the respective filter list support site, or at [uBlockOrigin/uAssets](https://github.com/uBlockOrigin/uAssets/issues). Use [the logger](https://github.com/gorhill/uBlock/wiki/The-logger) to diagnose/confirm filter-related issues. If something does not work properly with uBO enabled, the **first step** is to rule out filter-related issues.
-
-Ignorance of the above rules is no excuse: **Opening an issue for purpose of support or discussion, or opening a filter-related issue will result in the user being immediately blocked.** Given the [amount of invalid issues being opened](https://github.com/gorhill/uBlock/issues?q=is%3Aissue+label%3Ainvalid+is%3Aclosed), I have no choice but to resort to such a drastic measure.
-
-**The issue tracker is for provable issues only:** You will have to make the case that the issue is really with uBlock Origin and not something else on your side. To make a case means to provide detailed steps so that anybody can reproduce the issue. Be sure to rule out that the issue is not caused by something specific on your side.
-
-**Any issue opened without effort to provide the required details for me (or anybody else) to reproduce the problem will be closed as _invalid_.** If you provide more details thereafter for me to reproduce the issue, I will reopen it if I can confirm there is indeed an issue with uBlock Origin. Example of detailed steps:
-
-> 1. browser version/ublock version
-> 1. these settings, these filter lists, these custom filters.
-> 1. do this.
-> 1. open this exact URL.
-> 1. do this.
-> 1. observe this.
-> 1. click this.
-> 1. observe such and such issue
-> 1. see screenshot
-> 1. etc.
-
-The most important part when opening an issue: **detailed steps**.
-
-**Important:** I simply do not have the time to take care of filter-related issues, you will have to find help elsewhere for this. The mere need to have to respond to filter-related issues can quickly become a burden. Consider that writing code/doc occupies all my free time. Surely there are other people out there ready to help with filter-related issues, it does not have to be me.
-
-***
-
-### Before you submit
-
-1. Submit **bugs/issues only**.
-    - Bugs occur, I will fix them.
-1. _One specific_ issue per submission.
-1. The logger is the tool of choice to use to help diagnose issues.
-1. Do **NOT**:
-    - Submit pull requests.
-    - Submit design ideas.
-    - Submit feature requests.
-    - Submit "revolutionary ideas".
-    - Post comments like "+1" or "me too!" without providing new relevant info on the issue.
-    - Use issues as replacement for threads on a bulletin board.
-    - Any such issue will be closed without comment.
-    - Ask me to publish the latest version to AMO/Chrome store: In all likelihood it is already published, but pending review, something which is out of my control.
-1. Make sure your issue [hasn't already been fixed in a recent release](https://github.com/gorhill/uBlock/releases).
-1. Verify that the issue does **not** occur with uBlock disabled.
-1. **Verify that the issue is not related to a 3rd-party filter lists.**
-    - Issues with 3rd-party filter lists are the responsibility of their respective maintainers.
-1. Verify that the issue is not caused by another extension.
-1. Do not submit issues which can be reproduced **only** on Chrome Canary or Firefox Nightly: these are not stable browser versions and in all likelihood, whatever issue is not within uBO.
-    - Report **only** if you can reproduce in an official stable release, or a beta release.
-
-***
-
-### What to include
-
-To help diagnose and fix the bug/issue, please always include the following in your report:
-
-* A clear list of steps to reproduce the problem
-  * **ALWAYS INCLUDE A SPECIFIC URL WHERE THE ISSUE OCCURS**, _even_ if "it happens everywhere".
-* Symptoms of the issue
-  * Describe what you observe and consider broken behavior; this is what we'll be looking for after executing the steps
-  * Example: video doesn't start playing, page layout broken
-* Include whatever relevant the logger reports.
-* A screenshot or transcription of **any of uBlock's preferences that differ from the defaults**
-  * This includes a whitelisted website, enabled/disabled filter list, anything
-  * Please do include everything different from the defaults whether or not it seems relevant to your issue
-* The version of uBlock you're having the issue with; you can find this in [uBlock's popup UI](https://github.com/gorhill/uBlock/wiki/Quick-guide:-popup-user-interface)
-  * Example: `uBlock 0.9.0.0`
-* The browser you're using and its version
-  * Examples: `Firefox 36`, `Chrome 41.0.2272` 
-* The OS you're using and its version
-  * Examples: `Windows 8.1`, `Linux Mint 17.1`
-* A list of other extensions you have installed
-  * Tip: try disabling them and see if your issue still occurs
-
-Otherwise, we've noticed that a lot of **your** time (and the developers') gets thrown away on exchanging back and forth to get this information.
-
-***
-
-**Good read:** [How to Report Bugs Effectively](http://www.chiark.greenend.org.uk/~sgtatham/bugs.html).
+Issue tracker here is read-only for non-[prior contributors](https://github.com/gorhill/uBlock/graphs/contributors).