-
Notifications
You must be signed in to change notification settings - Fork 31
Update axios to 1.8.2 in e2e tests #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This goes a major bump. Are we sure there aren't any untested breaking changes? |
I guess I don't have perms on this repo to view https://github.com/elastic/apm-aws-lambda/security/dependabot/43 |
These e2e-testing bits are, I gather, very out of date. It looks like the e2e-testing bits aren't run regularly.
This
@rockdaboot Do you have a preference here? We could (a) take this PR as is; (b) use this or a separate PR to make these other updates. I'm happy to do the quick updates for (b). |
@trentm It looks like (b) would be the proper thing to do. I'd would be great if you can do it! |
This removes deps not being used by the 'sam-testing-nodejs' package used in e2e-testing. It bumps elastic-apm-node to its current major version. This also makes some attempts to get e2e-testing working again, but ultimately I did not get far. e2e-testing looks to not have been updated for changes in how the apm-lambda-extension is now built. Obsoletes: elastic#624
|
This removes deps not being used by the 'sam-testing-nodejs' package used in e2e-testing. It bumps elastic-apm-node to its current major version. This also makes some attempts to get e2e-testing working again, but ultimately I did not get far. e2e-testing looks to not have been updated for changes in how the apm-lambda-extension is now built. Obsoletes: #624
Closing in favor of #626 |
Fixes https://github.com/elastic/apm-aws-lambda/security/dependabot/43