Skip to content

Spec service.environment for logs #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Feb 10, 2023

  • add service.environment to the fields used for log correlation
  • move log correlation fields from log-reformatting to log-correlation
  • clarify the expected behavior when ECS logging is used in the application and agent providing fallback values.

Relates to #765

Follow-up tasks

  • open PR to add this to documentation

  • May the instrumentation collect sensitive information, such as secrets or PII (ex. in headers)?
    • n/a: only relates to log-correlation, which does not deal with sensitive data.
  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Approved by at least 2 agents + PM (if relevant)
  • Merge after 7 days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.
  • Create implementation issues through the meta issue template (this will automate issue creation for individual agents)
  • If this spec adds a new dynamic config option, add it to central config. n/a

@apmmachine
Copy link

apmmachine commented Feb 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T05:22:00.029+0000

  • Duration: 3 min 49 sec

@SylvainJuge SylvainJuge marked this pull request as ready for review February 28, 2023 10:52
@SylvainJuge SylvainJuge requested review from a team as code owners February 28, 2023 10:52
@SylvainJuge SylvainJuge removed request for a team February 28, 2023 10:53
@SylvainJuge SylvainJuge merged commit d40c1a6 into elastic:main Mar 8, 2023
@SylvainJuge SylvainJuge deleted the spec-log-correlation branch March 8, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants