ES secure settings finalizer hangs #1275
Description
Sometimes when I try to delete an ES instance, it can get hung with a malformed finalizer on it. Deleting the finalizer lets it delete, but I wonder why it happens in the first place. Here's the ES object once it gets into that state
apiVersion: elasticsearch.k8s.elastic.co/v1alpha1
kind: Elasticsearch
metadata:
annotations:
common.k8s.elastic.co/controller-version: 0.9.0-SNAPSHOT
creationTimestamp: "2019-07-17T21:34:16Z"
deletionGracePeriodSeconds: 0
deletionTimestamp: "2019-07-18T00:08:32Z"
finalizers:
- secure-settings.finalizers..k8s.elastic.co
generation: 2
name: elasticsearch-sample
namespace: e2eand gist of the operator logs grepping for the ES name:
https://gist.github.com/anyasabo/11c93f3e016418efef9cea60bc66198a
You'll see there's a couple logs of it executing but not getting removed.
{"level":"info","ts":1563397407.7224836,"logger":"finalizer","msg":"Registering finalizer","finalizer_name":"secure-settings.finalizers..k8s.elastic.co","namespace":"e2e","name":"elasticsearch-sample"}
...
{"level":"info","ts":1563399256.390922,"logger":"finalizer","msg":"Registering finalizer","finalizer_name":"secure-settings.finalizers..k8s.elastic.co","namespace":"e2e","name":"elasticsearch-sample"}I see we do some string manipulation here that looks like it might be responsible, since if getKind() returns the empty string then it would produce that finalizer. I don't know enough about how all this fits together to come up with a complete root cause, but wanted to open the issue to track it. I didn't see any existing ones similar to this at the moment.