-
Notifications
You must be signed in to change notification settings - Fork 16
Publish ECS 9.0.0 documentation #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would like this to publish the "9.0" branch of the ecs repo, I'm not completely sure if this is the correct way to do it. If it's possible to publish tags, I can also change this to publish I also don't have permission to add a label to this PR, to make the "required-labels / check-labels" check happy here, so could someone add a label for me? |
Hi @mjwolf, Thank you for your contribution! To be honest, we don't have a proper current/next strategy yet. Let's wait for @Mpdreamz or @bmorelli25's opinion. |
The change looks good to me and config wise I don't expect this to change. Our current/next strategy is defined in the sense we provide the following options:
What's not defined is what repositories will use what strategy. We have a techical blocker in that we are not currently setup to publish from We currently require Our workflow is currently only triggering on |
This is needed to start onboarding `9.0` to the documentation build elastic/docs-builder#1180
This is now correctly failing because ![]() elastic/ecs#2476 should now be ready to be merged upstream (and backported to |
This is needed to start onboarding `9.0` to the documentation build elastic/docs-builder#1180
This is needed to start onboarding `9.0` to the documentation build elastic/docs-builder#1180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Did a full assemble production build locally and hit no errors.
Update assembler config to publish ECS v9.0.0 documentation as the current version.