-
Notifications
You must be signed in to change notification settings - Fork 84
apm: Document sampling.tail.ttl config #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should hold off from merging it until 9.1 and 8.19 release, because having these unreleased versions in public docs can be confusing.
### Version 8.19+ and 9.1+ [ec_version_8_19_and_9_1] | ||
|
||
`apm-server.sampling.tail.ttl` | ||
: Time-to-live (TTL) for trace events stored in the local storage of the APM Server during tail-based sampling. This TTL determines how long trace events are retained in the local storage while waiting for a sampling decision to be made. A greater TTL value increases storage space requirements. | ||
|
||
### Version 8.0+ [ec_version_8_0_3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[to reviewer] I'm starting to think we should remove all 7.x and 8.x sections, as this is 9.0 docs. It still makes sense to document 9.0 vs 9.1+ though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but if you don't want this to be published until 9.1 you should hold off on merging as you mentioned.
(Spoiler: We're working on some changes to how to handle PRs like this that contain content for future versions and how to annotate version applicability of individual settings. If these features are available in docs-builder before the 9.1 release, I'll make updates here.)
| | | | ||
| --- |---------------------| | ||
| APM Server binary | `sampling.tail.ttl` | | ||
| Fleet-managed | `TTL` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME: add a note about fleet managed is only available from 9.1
| | | | ||
| --- |---------------------| | ||
| APM Server binary | `sampling.tail.ttl` | | ||
| Fleet-managed | `TTL` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Document
sampling.tail.ttl
configRelated to #769
Part of elastic/apm-server#13525