Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 11, 2019

direct_html is faster and more customizable. It is the future!

direct_html is faster and more customizable. It is the future!
@nik9000 nik9000 requested a review from jbaiera December 11, 2019 22:53
@nik9000
Copy link
Member Author

nik9000 commented Dec 11, 2019

This PR will make a diff and I'll check the diff. If it looks good then I'll merge this. If it doesn't I'll iterate on --direct_html until it does.

@nik9000
Copy link
Member Author

nik9000 commented Dec 11, 2019

That particular failure is one that I've been trying to fix in the source repos. I'll open a PR.

@nik9000
Copy link
Member Author

nik9000 commented Dec 12, 2019

elastic/elasticsearch-hadoop#1408 will fix the error!

@nik9000
Copy link
Member Author

nik9000 commented Dec 12, 2019

@elasticmachine, run elasticsearch-ci/docs

@nik9000
Copy link
Member Author

nik9000 commented Dec 12, 2019

This needs:

@nik9000
Copy link
Member Author

nik9000 commented Dec 13, 2019

Diff looks good!

@jbaiera, please add --direct_html the next time you build the docs.

@nik9000
Copy link
Member Author

nik9000 commented Dec 13, 2019

And pull the docs repo!

@nik9000 nik9000 merged commit cac65b1 into elastic:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant