Skip to content

Small fixes #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Small fixes #101

merged 3 commits into from
Nov 30, 2023

Conversation

MrSnapperVibes
Copy link
Contributor

Repeat of #100 because CI in order to fix CI issues.

  • Remove unused imports
  • Undefined name index

@MrSnapperVibes
Copy link
Contributor Author

Hmm, it looks like we're stuck in CI again.

This particular pull request is not a big deal. This library is useful and I'd love to be helpful, but there doesn't appear that there's much that needs done 🙂

@basepi
Copy link
Contributor

basepi commented Nov 29, 2023

Yeah but I also need to figure out why the CI isn't running 🤔

Appreciate your patience.

@elastic/observablt-ci any ideas why these tests aren't running? They don't even show up under the "Checks" tab where I could restart them.

@v1v
Copy link
Member

v1v commented Nov 29, 2023

@elastic/observablt-ci any ideas why these tests aren't running?

For some reason, this project has been configured with:

image

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

I'll change the settings now

@v1v v1v closed this Nov 29, 2023
@v1v v1v reopened this Nov 29, 2023
@v1v
Copy link
Member

v1v commented Nov 29, 2023

according to this

If you are comfortable with running workflows on the pull request branch, return to the Conversation tab, and under "Workflow(s) awaiting approval", click Approve and run.

But I cannot see anything, in theory, something like the below screenshot should be shown

image

@v1v
Copy link
Member

v1v commented Nov 29, 2023

And I've just seen this

image

and that's the reason!

Warning: To prevent unnecessary workflow runs, scheduled workflows may be disabled automatically. When a public repository is forked, scheduled workflows are disabled by default. In a public repository, scheduled workflows are automatically disabled when no repository activity has occurred in 60 days.

Even though the workflow supports different events in addition to the scheduler :/

Just found this issue

@v1v v1v closed this Nov 29, 2023
@v1v v1v reopened this Nov 29, 2023
@basepi
Copy link
Contributor

basepi commented Nov 30, 2023

@elasticmachine, run elasticsearch-ci/docs

@basepi basepi enabled auto-merge (squash) November 30, 2023 00:32
@basepi basepi merged commit 7f304be into elastic:main Nov 30, 2023
@MrSnapperVibes MrSnapperVibes deleted the small-fixes branch November 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants