Skip to content

support lists #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

camerondavison
Copy link
Contributor

@camerondavison camerondavison commented Aug 25, 2020

Closes #21

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 25, 2020

💚 CLA has been signed

@camerondavison
Copy link
Contributor Author

I signed the CLA

@apmmachine
Copy link
Contributor

apmmachine commented Aug 25, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Seth Michael Larson, Replayed #3]

  • Start Time: 2020-08-27T13:26:46.032+0000

  • Duration: 7 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 151
Skipped 5
Total 156

@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson
Copy link
Contributor

Looks like linting failed, could you run nox -s blacken to fix some of the issues?

09:08:14  nox > Running session lint
09:08:14  nox > Creating virtual environment (virtualenv) using python in .nox/lint
09:08:15  nox > pip install flake8 black mypy
09:08:25  nox > black --check --target-version=py27 noxfile.py tests/ ecs_logging/
09:08:25  would reformat /var/lib/jenkins/workspace/hon_ecs-logging-python-mbp_PR-22/src/go.elastic.co/apm/ecs-logging-python/tests/test_utils.py
09:08:25  Oh no! 💥 💔 💥
09:08:25  1 file would be reformatted, 12 files would be left unchanged.
09:08:25  nox > Command black --check --target-version=py27 noxfile.py tests/ ecs_logging/ failed with exit code 1
09:08:25  nox > Session lint failed.

@sethmlarson sethmlarson merged commit 748f74d into elastic:master Aug 27, 2020
@sethmlarson
Copy link
Contributor

Thanks for this change! 🎉

@camerondavison
Copy link
Contributor Author

Sure thing. When do y'all do releases so I can get the change deployed into my env?

@sethmlarson
Copy link
Contributor

I can create a release for this today probably.

@camerondavison camerondavison deleted the cd-lists-fixes-21 branch August 27, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not support a dictionary of list of strings
3 participants