Ensure @timestamp, log.level, and message fields are ordered per spec #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
ordered-fields
branch
from
b4d8331 to
ad693ac
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
basepi
approved these changes
Jan 7, 2021
|
A lot of the not-great code is for the JSON serializer, gonna try subclassing JSONEncoder and see if that's any better? |
|
The |
Rawk
added a commit
to Rawk/ecs-logging-python
that referenced
this pull request
Jan 25, 2021
Update example output after changes in elastic#28 .
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #26