Skip to content

Remove installation instructions from readme #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove installation instructions from readme #30

merged 2 commits into from
Jan 15, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jan 15, 2021 •
edited
Loading

Summary

Docs are up! This PR removes the installation instructions from the readme and links to elastic.co. Feel free to change the wording or layout.

Related

Closes #27

@bmorelli25 bmorelli25 added the documentation Improvements or additions to documentation label Jan 15, 2021
@bmorelli25 bmorelli25 requested a review from basepi January 15, 2021 01:02
@bmorelli25 bmorelli25 mentioned this pull request Jan 15, 2021
Closed
5 tasks
@apmmachine
Copy link
Contributor

apmmachine commented Jan 15, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #30 updated

    • Start Time: 2021-01-15T16:19:11.484+0000

  • Duration: 6 min 28 sec

  • Commit: 3d334f0

Test stats 🧪

Test Results
Failed 0
Passed 233
Skipped 8
Total 241

@sethmlarson
Copy link
Contributor

sethmlarson commented Jan 15, 2021 •
edited
Loading

May I suggest leaving the $ python -m pip install ecs-logging somewhere in the README? Only because the package on PyPI is different than the repo name.

Otherwise LGTM

basepi
basepi approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your help!

sethmlarson
sethmlarson approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit a1198f3 into elastic:master Jan 15, 2021
@bmorelli25 bmorelli25 deleted the remove-readme-docs branch January 15, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Add ecs-logging-python to the Elastic doc build
4 participants
@bmorelli25 @apmmachine @sethmlarson @basepi