Skip to content

Validate against spec #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2021
Merged

Validate against spec #31

merged 5 commits into from
Jan 19, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jan 15, 2021

This adds validation against the upstream spec.

Fixes #26

@apmmachine
Copy link
Contributor

apmmachine commented Jan 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #31 updated

    • Start Time: 2021-01-19T16:21:47.366+0000
  • Duration: 6 min 30 sec

  • Commit: e3986bb

Test stats 🧪

Test Results
Failed 0
Passed 233
Skipped 8
Total 241

@basepi
Copy link
Contributor Author

basepi commented Jan 16, 2021

I'll fix up the datetime issues on Monday.

Copy link

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small detail

@basepi basepi merged commit 39b04a9 into elastic:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META 27] Align ecs-logging-python
3 participants