Skip to content

Add support for service.name #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add support for service.name #32

merged 1 commit into from
Jan 21, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jan 21, 2021

As of 5.10.1, elastic-apm provides service.name as one of the log correlation fields. This PR supports that new addition.

beniwohli
beniwohli approved these changes Jan 21, 2021
View reviewed changes
Copy link

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #32 opened

    • Start Time: 2021-01-21T16:02:15.143+0000

  • Duration: 8 min 36 sec

  • Commit: bab94b9

Test stats 🧪

Test Results
Failed 0
Passed 233
Skipped 8
Total 241

@basepi basepi merged commit 1ad2d97 into elastic:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beniwohli beniwohli beniwohli approved these changes

@sethmlarson sethmlarson Awaiting requested review from sethmlarson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basepi @apmmachine @beniwohli