Skip to content

Match StdlibFormatter signature with logger.Formatter #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2021
Merged

Match StdlibFormatter signature with logger.Formatter #54

merged 5 commits into from
Aug 13, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 10, 2021

Fixes #53

@basepi basepi requested a review from sethmlarson August 10, 2021 16:46
@basepi basepi mentioned this pull request Aug 10, 2021
Closed
sethmlarson
sethmlarson approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a test case for this? Maybe we can instantiate an ecs_logging.StdlibFormatter via dictConfig as an integration test?

@apmmachine
Copy link
Contributor

apmmachine commented Aug 10, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-13T16:48:18.975+0000

  • Duration: 8 min 8 sec

  • Commit: f23783a

Test stats 🧪

Test Results
Failed 0
Passed 248
Skipped 11
Total 259

Trends 🧪

Image of Build Times

Image of Tests

@basepi basepi force-pushed the stdlibsignature53 branch from b75aca3 to 3c1bcab Compare August 11, 2021 17:15
@basepi
Add a test
0c543f1 
Also fix mypy settings for tests and noxfile
@basepi basepi force-pushed the stdlibsignature53 branch from 3c1bcab to 0c543f1 Compare August 11, 2021 17:17
sethmlarson
sethmlarson approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basepi basepi force-pushed the stdlibsignature53 branch from 10f32ad to 2ab9764 Compare August 12, 2021 17:53
@basepi basepi force-pushed the stdlibsignature53 branch from dc14cdd to 14a1636 Compare August 13, 2021 16:30
@basepi basepi merged commit dfcc0d8 into elastic:master Aug 13, 2021
@zhuopeng
Copy link

hi, mind to release a new version with the fix?

@basepi
Copy link
Contributor Author

basepi commented Sep 22, 2021

@zhuopeng Yes I can do that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StdlibFormatter has an incorrect constructor signature
4 participants
@basepi @apmmachine @zhuopeng @sethmlarson