Skip to content

Use setdefault to avoid overriding user values for apm fields #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2021
Merged

Use setdefault to avoid overriding user values for apm fields #67

merged 1 commit into from
Oct 12, 2021

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Oct 12, 2021

Fixes #66

@basepi basepi mentioned this pull request Oct 12, 2021
Closed
@basepi basepi self-assigned this Oct 12, 2021
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-12T16:51:05.123+0000

  • Duration: 8 min 22 sec

  • Commit: 74f4394

Test stats 🧪

Test Results
Failed 0
Passed 209
Skipped 4
Total 213

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

sethmlarson
sethmlarson approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basepi basepi merged commit 9951e76 into elastic:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@beniwohli beniwohli Awaiting requested review from beniwohli

Assignees

@basepi basepi

Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service.name is set to None because of elasticapm_service_name
3 participants
@basepi @apmmachine @sethmlarson