Skip to content

Remove python 2 support #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Remove python 2 support #78

merged 5 commits into from
Jan 11, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jan 11, 2022

As discussed with @sethmlarson, the python client is removing support for python 2 in 8.0, so ecs-logging-python can follow suit. 🎉

We'll want to move from comment-based type checking to python 3 type hints but I think that should be a separate PR.

@basepi basepi self-assigned this Jan 11, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jan 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-11T18:10:21.308+0000

  • Duration: 9 min 56 sec

  • Commit: b174939

Test stats 🧪

Test Results
Failed 0
Passed 269
Skipped 0
Total 269

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one blocking comment from me. A non-blocking comment: have you tried pyupgrade --py36-plus and flynt on the codebase? Might change some string formatting into f-strings and other modernizations.

@basepi basepi requested a review from sethmlarson January 11, 2022 18:10
@basepi
Copy link
Contributor Author

basepi commented Jan 11, 2022

Ran flynt/pyupgrade and fixed up a few things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants