Clean up response 'close' event #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
HttpConnection
, the'close'
handler for a response was being cleaned up implicitly, since all its listeners should be dropped when the object is garbage collected at the end of a request/response cycle. However, as @pmuellr noted here, explicitly cleaning it up removes ambiguity and the potential for unexpected edge case errors when a system is under heavy load.This also updates the error message provided to
ConnectionError
in a'close'
event to distinguish it from another similar circumstance that can also raise anEPIPE
error.