Bring _transport.py closer to _async_transport.py #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By taking advantage of NodeApiResponse and avoiding meaningless differences.
ezimuel
reviewed
Feb 9, 2024
ezimuel
left a comment
ezimuel
left a comment
There was a problem hiding this comment.
I left a comment about logging potential sensitive information.
| % (method, node.base_url, target, "N/A", time.time() - start_time) | ||
| % ( | ||
| method, | ||
| node.base_url, |
There was a problem hiding this comment.
This is a more general topics, we should remove potential sensitive information in the logger. In this case an URL can contains username:password and I'm not sure about target. We should think to have a filter or a redact strategy, here an example.
Member
Author
There was a problem hiding this comment.
Thanks! We agreed offline to handle this in a different pull request, so I'll merge this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By taking advantage of NodeApiResponse and avoiding meaningless differences. The closer they are, the easier they are to compare.