Re-evaluate predicate in FnCondition.whenReadyIf as the predicate may… #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have changed while awaiting the condition
|
Very good catch @ginkel! Concurrency is hard... Thanks a lot for the patch! |
swallez
pushed a commit
that referenced
this pull request
Feb 13, 2023
… have changed while awaiting the condition (#502)
swallez
pushed a commit
that referenced
this pull request
Feb 13, 2023
… have changed while awaiting the condition (#502)
swallez
added a commit
that referenced
this pull request
Feb 13, 2023
… have changed while awaiting the condition (#502) (#511) Co-authored-by: Thilo-Alexander Ginkel <[email protected]>
swallez
added a commit
that referenced
this pull request
Feb 13, 2023
… have changed while awaiting the condition (#502) (#510) Co-authored-by: Thilo-Alexander Ginkel <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… have changed while awaiting the condition
During tests we noticed that the new
BulkIngestersporadically attempts to submit empty bulk requests (containing zero operations) causing an exception. Digging through the code the most probable cause is that the predicate supplied toFnCondition.whenReadyIfmay change duringcondition.awaitUninterruptibly()(which temporarily releases the lock), so the predicate needs to be re-evaluated after that call returns. This is what this PR implements.