Added support for version >= 8.0.0 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GenerateCertificatesTask now generates a certificate authority when version 8 detected * ClusterComposeTask ExecuteBinary now also ignores lines containing "using ES_JAVA_HOME"
* Added check back in GenerateCertificatesTask to skip certificate generation if certificate path already exists
|
💚 CLA has been signed |
|
Wow this is great and completely flew under my radar, apologies for getting to it so late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with using version 8 was that elasticsearch-certutil no longer generated a CA automatically. It is now a separate step in the setup. The GenerateCertificatesTask now generates a certificate authority when version 8 detected.
In addition version 8 also produces a slightly different warning message when JAVA_HOME is missing. The ClusterComposeTask ExecuteBinary now also ignores warning lines containing "using ES_JAVA_HOME".