Update generated examples #2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is insecure, though not in this specific context, but tools are flagging this.
There was a problem hiding this comment.
I think generally it looks good. I checked some of the code changes in the generated examples and they match with Ruby. A thing I'm doing when I generate the code is spin up Elasticsearch and run the generated example code against it. I log the successful runs and the errors to see if there's a client error or a server error (usually because a code example needs some setup). But I add all the successful requests since I'm sure those are fine, and can debug what's wrong with the rest using the logs.
JoshMock
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2266
@picandocodigo Since Ruby appears to be the most up-to-date client regarding examples, would you mind looking if the generated files look good and tell me if more needs to be done to have up-to-date example in the docs?