Skip to content

Added equality check for Connection class #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2019
Merged

Added equality check for Connection class #938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02df491
Added equality check for Connection class
paulefoe Apr 28, 2019
2b7389d
ES: make connection hashable
paulefoe May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions elasticsearch/connection/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ def __init__(self, host='localhost', port=9200, use_ssl=False, url_prefix='', ti
def __repr__(self):
return '<%s: %s>' % (self.__class__.__name__, self.host)

def __eq__(self, other):
if not isinstance(other, Connection):
raise TypeError(
"Unsupported equality check for %s and %s" % (self, other)
)
return True

def __hash__(self):
return id(self)

def _pretty_json(self, data):
# pretty JSON in tracer curl logs
try:
Expand Down