Skip to content

Adding resolve_during_rolling_upgrade and _meta to the deprecation info API response #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Dec 2, 2024

The resolve_during_rolling_upgrade and _meta fields (added sometime in 7.x) had been missing from the deprecation info api response definition. This also clarifies that the details field in the response is optional.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
migration.deprecations 🟢 2/2 2/2

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pquentin pquentin merged commit 6874bee into main Dec 3, 2024
11 checks passed
@pquentin pquentin deleted the adding-missing-deprecation-info-fields branch December 3, 2024 13:32
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Anaethelion pushed a commit that referenced this pull request Dec 3, 2024
…fo API response (#3203) (#3212)

(cherry picked from commit 6874bee)

Co-authored-by: Keith Massey <[email protected]>
Anaethelion pushed a commit that referenced this pull request Dec 3, 2024
…fo API response (#3203) (#3213)

(cherry picked from commit 6874bee)

Co-authored-by: Keith Massey <[email protected]>
Anaethelion pushed a commit that referenced this pull request Dec 3, 2024
…fo API response (#3203) (#3214)

(cherry picked from commit 6874bee)

Co-authored-by: Keith Massey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants