Skip to content

[ML] Inference task type separation 8.18 #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

[ML] Inference task type separation 8.18 #3904

merged 2 commits into from
Mar 7, 2025

Conversation

jonathan-buttner
Copy link
Contributor

This PR backports #3545 to 8.x. The automatic backport failed so I'm manually backporting it.

jonathan-buttner and others added 2 commits March 6, 2025 16:20
@jonathan-buttner
Inference task type endpoints (#3545)
7241468 
* Refactoring inference endpoints

* Fixing stream completion url and removing the old url and class

* generating spec

* Adding doc id

* Renaming to match filename

* Switching to stream and regenerating files

* Using variant and adding _stream

* Removing variant

* Adding chat_completion and fixing update api

* Resolving conflicts
@jonathan-buttner
Fixing merge conflicts
723386a
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.chat_completion_unified ⚪ Missing test Missing test
inference.completion ⚪ Missing test Missing test
inference.delete ⚪ Missing test Missing test
inference.get 🟢 1/1 1/1
inference.put_watsonx ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test
inference.rerank ⚪ Missing test Missing test
inference.sparse_embedding ⚪ Missing test Missing test
inference.stream_completion ⚪ Missing test Missing test
inference.text_embedding ⚪ Missing test Missing test
inference.update ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@jonathan-buttner jonathan-buttner requested a review from a team March 6, 2025 21:24
davidkyle
davidkyle approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner jonathan-buttner merged commit 339d4bf into 8.18 Mar 7, 2025
7 checks passed
@jonathan-buttner jonathan-buttner deleted the ml-inference-task-type-separation-8.18 branch March 7, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-buttner @davidkyle