Skip to content

Remove redundant overlays #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Remove redundant overlays #3905

merged 6 commits into from
Mar 12, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 7, 2025

This PR follows #3737 and removes the overlays that it renders redundant.

It also changes the example file names to be unique since I'm concerned the generic "RequestExample1" and "ResponseExample1" file names (for example) might cause problems if they're used in the shared schema section of the OpenAPI document.

@swallez swallez force-pushed the feature/openapi-examples branch from 17dfe3e to b594e24 Compare March 12, 2025 16:25
Base automatically changed from feature/openapi-examples to main March 12, 2025 16:32
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ilm.migrate_to_data_tiers Missing test Missing test
indices.downsample 🟢 3/3 3/3
searchable_snapshots.cache_stats Missing test Missing test
security.activate_user_profile 🟢 9/9 9/9
security.enroll_kibana Missing test Missing test
security.enroll_node Missing test Missing test
security.get_user_profile 🟢 8/8 8/8
security.has_privileges_user_profile 🟢 3/3 3/3
security.oidc_authenticate Missing test Missing test
security.oidc_logout Missing test Missing test
security.oidc_prepare_authentication Missing test Missing test
security.saml_authenticate Missing test Missing test
security.saml_complete_logout Missing test Missing test
security.saml_invalidate Missing test Missing test
security.saml_logout Missing test Missing test
security.saml_prepare_authentication Missing test Missing test
security.saml_service_provider_metadata Missing test Missing test
security.suggest_user_profiles 🟢 1/1 1/1
security.update_api_key 🟢 5/5 5/5
security.update_user_profile_data 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review March 12, 2025 20:05
@lcawl lcawl requested a review from a team March 12, 2025 20:05
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ilm.migrate_to_data_tiers Missing test Missing test
indices.downsample 🟢 3/3 3/3
searchable_snapshots.cache_stats Missing test Missing test
security.activate_user_profile 🟢 9/9 9/9
security.enroll_kibana Missing test Missing test
security.enroll_node Missing test Missing test
security.get_user_profile 🟢 8/8 8/8
security.has_privileges_user_profile 🟢 3/3 3/3
security.oidc_authenticate Missing test Missing test
security.oidc_logout Missing test Missing test
security.oidc_prepare_authentication Missing test Missing test
security.saml_authenticate Missing test Missing test
security.saml_complete_logout Missing test Missing test
security.saml_invalidate Missing test Missing test
security.saml_logout Missing test Missing test
security.saml_prepare_authentication Missing test Missing test
security.saml_service_provider_metadata Missing test Missing test
security.suggest_user_profiles 🟢 1/1 1/1
security.update_api_key 🟢 5/5 5/5
security.update_user_profile_data 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ilm.migrate_to_data_tiers Missing test Missing test
indices.downsample 🟢 3/3 3/3
searchable_snapshots.cache_stats Missing test Missing test
security.activate_user_profile 🟢 9/9 9/9
security.enroll_kibana Missing test Missing test
security.enroll_node Missing test Missing test
security.get_user_profile 🟢 8/8 8/8
security.has_privileges_user_profile 🟢 3/3 3/3
security.oidc_authenticate Missing test Missing test
security.oidc_logout Missing test Missing test
security.oidc_prepare_authentication Missing test Missing test
security.saml_authenticate Missing test Missing test
security.saml_complete_logout Missing test Missing test
security.saml_invalidate Missing test Missing test
security.saml_logout Missing test Missing test
security.saml_prepare_authentication Missing test Missing test
security.saml_service_provider_metadata Missing test Missing test
security.suggest_user_profiles 🟢 1/1 1/1
security.update_api_key 🟢 5/5 5/5
security.update_user_profile_data 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@wajihaparvez
Copy link

🚗 😄

@lcawl lcawl merged commit 54815a4 into main Mar 12, 2025
8 checks passed
@lcawl lcawl deleted the rm-overlays branch March 12, 2025 20:20
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3905-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 54815a4d45af469132611ebc550d1990100aad0a
# Push it to GitHub
git push --set-upstream origin backport-3905-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3905-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3905-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 54815a4d45af469132611ebc550d1990100aad0a
# Push it to GitHub
git push --set-upstream origin backport-3905-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3905-to-8.18.

github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
(cherry picked from commit 54815a4)
lcawl added a commit that referenced this pull request Mar 12, 2025
(cherry picked from commit 54815a4)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 12, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 12, 2025
(cherry picked from commit 54815a4)
@lcawl
Copy link
Contributor Author

lcawl commented Mar 12, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Mar 12, 2025
(cherry picked from commit 54815a4)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Mar 12, 2025
lcawl added a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants