Skip to content

Use correct status values for simulated ingest pipeline processor results #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Use correct status values for simulated ingest pipeline processor results #4292

merged 2 commits into from
Apr 28, 2025

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock mentioned this pull request Apr 17, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_ip_location_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_ip_location_database 🟢 7/7 7/7
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_ip_location_database 🟢 4/4 4/4
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@JoshMock JoshMock requested review from pquentin, l-trotta and a team April 22, 2025 15:38
l-trotta
l-trotta approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server side proof, LGTM

@JoshMock JoshMock merged commit 7e8ca46 into main Apr 28, 2025
14 checks passed
@JoshMock JoshMock deleted the pipeline-simulation-status branch April 28, 2025 16:14
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@JoshMock @github-actions
Use correct status values for simulated ingest pipeline processor res…
fa9b47f 
…ults (#4292)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@JoshMock @github-actions
Use correct status values for simulated ingest pipeline processor res…
495ae43 
…ults (#4292)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@JoshMock @github-actions
Use correct status values for simulated ingest pipeline processor res…
0fb14cf 
…ults (#4292)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
flobernd pushed a commit that referenced this pull request Apr 29, 2025
@github-actions @JoshMock
Use correct status values for simulated ingest pipeline processor res…
bc9ac47 
…ults (#4292) (#4314)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
flobernd pushed a commit that referenced this pull request Apr 29, 2025
@github-actions @JoshMock
Use correct status values for simulated ingest pipeline processor res…
c05b36a 
…ults (#4292) (#4315)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
flobernd pushed a commit that referenced this pull request Apr 29, 2025
@github-actions @JoshMock
Use correct status values for simulated ingest pipeline processor res…
d613f5e 
…ults (#4292) (#4316)

* Ingest pipeline simulation response status options were wrong

* Rename to something more helpful

(cherry picked from commit 7e8ca46)

Co-authored-by: Josh Mock <joshua.mock@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-trotta l-trotta l-trotta approved these changes

@pquentin pquentin Awaiting requested review from pquentin

Assignees
No one assigned
Labels
backport 8.18 backport 8.19 backport 9.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IngestPipelineSimulation] Typing error on exported type
2 participants
@JoshMock @l-trotta