-
Notifications
You must be signed in to change notification settings - Fork 108
[compiler] Rename external to typed_keys_quirk #4619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
swallez
reviewed
Jun 19, 2025
Co-authored-by: Sylvain Wallez <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
swallez
approved these changes
Jun 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors Co-authored-by: Sylvain Wallez <[email protected]> --------- Co-authored-by: Sylvain Wallez <[email protected]> (cherry picked from commit d2baac0)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors Co-authored-by: Sylvain Wallez <[email protected]> --------- Co-authored-by: Sylvain Wallez <[email protected]> (cherry picked from commit d2baac0)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors Co-authored-by: Sylvain Wallez <[email protected]> --------- Co-authored-by: Sylvain Wallez <[email protected]> (cherry picked from commit d2baac0)
Anaethelion
added a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors --------- (cherry picked from commit d2baac0) Co-authored-by: Laurent Saint-Félix <[email protected]> Co-authored-by: Sylvain Wallez <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors --------- (cherry picked from commit d2baac0) Co-authored-by: Laurent Saint-Félix <[email protected]> Co-authored-by: Sylvain Wallez <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 19, 2025
* rename external to typed_keys_quirk in compiler * propagate renaming to the specification files * adapt the documentation to reflect the new name * enhance typed_keys_quirk warning usage for contributors --------- (cherry picked from commit d2baac0) Co-authored-by: Laurent Saint-Félix <[email protected]> Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the variant name
external
totyped_keys_quirk
to better highlight its specific use.The real external tagging being
container
resolving types by the field name and able to be non-exhaustive.The internal naming
external_tag
remains intact for backward compatibility with existing generators.