Skip to content

Adds cat node -h enumerated values #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 1, 2025
Merged

Adds cat node -h enumerated values #4736

merged 6 commits into from
Jul 1, 2025

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Jul 1, 2025

This PR adds the enumerated values for the -h parameter in the following APIs:

Related issue: #4345

@kosabogi kosabogi requested review from pquentin and lcawl July 1, 2025 10:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Following you can find the validation changes for the API you have modified.

API Status Request Response
cat.recovery 🟢 → 🔴 6/6 → 2/6 6/6

You can validate this API yourself by using the make validate target.

pquentin
pquentin reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation is failing because you were using the string version in two cases, not the string | string[] version.

pquentin
pquentin approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Validation now passes, but due to a weird behavior in the validation CI, it looks like it does not.

@pquentin pquentin merged commit 7b834b0 into main Jul 1, 2025
9 checks passed
@pquentin pquentin deleted the cat-h-recovery branch July 1, 2025 15:55
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@kosabogi @pquentin @github-actions
Adds cat node -h enumerated values (#4736)
f2f5424 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 7b834b0)
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@kosabogi @pquentin @github-actions
Adds cat node -h enumerated values (#4736)
24c42c0 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 7b834b0)
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@kosabogi @pquentin @github-actions
Adds cat node -h enumerated values (#4736)
bd4558a 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 7b834b0)
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@kosabogi @pquentin @github-actions
Adds cat node -h enumerated values (#4736)
5838594 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/recovery/CatRecoveryRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/cat/segments/CatSegmentsRequest.ts

Co-authored-by: Quentin Pradet <[email protected]>

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 7b834b0)
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
pquentin added a commit that referenced this pull request Jul 1, 2025
@github-actions @kosabogi @pquentin
Adds cat node -h enumerated values (#4736) (#4747)
7c363b9 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



---------


(cherry picked from commit 7b834b0)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 1, 2025
@github-actions @kosabogi @pquentin
Adds cat node -h enumerated values (#4736) (#4746)
996efac 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



---------


(cherry picked from commit 7b834b0)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 1, 2025
@github-actions @kosabogi @pquentin
Adds cat node -h enumerated values (#4736) (#4745)
e7d3fe0 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



---------


(cherry picked from commit 7b834b0)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 1, 2025
@github-actions @kosabogi @pquentin
Adds cat node -h enumerated values (#4736) (#4744)
3b8c6f8 
* Adds cat node -h enumerated values

* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/recovery/CatRecoveryRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



* Update specification/cat/segments/CatSegmentsRequest.ts



---------


(cherry picked from commit 7b834b0)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
@kosabogi
Copy link
Contributor Author

kosabogi commented Jul 2, 2025

Thanks! LGTM. Validation now passes, but due to a weird behavior in the validation CI, it looks like it does not.

Thank you for your review and for merging this PR!

@l-trotta l-trotta mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
backport 8.18 backport 8.19 backport 9.0 backport 9.1 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosabogi @pquentin