Update rest-api-spec main #4831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
skip-backport
github-actions
bot
requested review from
Anaethelion,
ezimuel,
flobernd,
JoshMock,
l-trotta,
miguelgrinberg,
picandocodigo,
pquentin,
swallez and
technige
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
pquentin
reviewed
Jul 8, 2025
Comment on lines
+155
to
+161
| /** | ||
| * Whether vectors should be excluded from _source | ||
| * @availability stack since=9.2.0 | ||
| * @availability serverless | ||
| * @server_default false | ||
| */ | ||
| _source_exclude_vectors?: boolean |
There was a problem hiding this comment.
@jimczi My understanding is that those query parameters are not behind a feature flag, only the new mappings are. So the query parameter will end up in 9.2.0 and Serverless. Is that correct?
pquentin
reviewed
Jul 8, 2025
| /** | ||
| * Filter out results, for example to filter out sensitive information. Supports wildcards or full settings keys | ||
| */ | ||
| settings_filter?: string | string[] |
There was a problem hiding this comment.
I considered Names instead but @Anaethelion tells me that it's safer to start from an union and maybe move to Names or another similar type alias later.
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.