Add wait_for_completion to snapshot.delete

[pquentin]

It's read here: https://github.com/elastic/elasticsearch/blob/8f641843636a669b9117a81ac0460d28fb51c4e5/server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestDeleteSnapshotAction.java#L66

And documented here: https://www.elastic.co/guide/en/elasticsearch/reference/8.18/delete-snapshot-api.html#delete-snapshot-api-query-params

[github-actions]

Following you can find the validation changes against the target branch for the API.

API	Status	Request	Response
snapshot.delete	🔴 → 🟢	22/24 → 24/24	24/24

You can validate this API yourself by using the make validate target.

[github-actions]

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4875-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05432996eea446c0053717fbaa1c126e1ce8e7d4
# Push it to GitHub
git push --set-upstream origin backport-4875-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4875-to-8.19.

[github-actions]

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4875-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05432996eea446c0053717fbaa1c126e1ce8e7d4
# Push it to GitHub
git push --set-upstream origin backport-4875-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4875-to-8.18.

[pquentin]

💚 All backports created successfully

Status	Branch	Result
✅	8.19
✅	8.18

Questions ?

Please refer to the Backport tool documentation