Skip to content

[9.1] Updates 'model_id' and 'input_type' as required parameters for Cohere V2 #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

kosabogi
Copy link
Contributor

This PR updates the model_id and input_type parameters to be required for the Cohere V2 inference endpoint starting from 9.1.

I also removed the default value for model_id, assuming that it no longer has one since it's now required. @davidkyle could you please confirm if this assumption is correct?

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

I also removed the default value for model_id, assuming that it no longer has one since it's now required. @davidkyle could you please confirm if this assumption is correct?

This is correct. Thanks @kosabogi

@kosabogi kosabogi merged commit a7876a8 into main Jul 15, 2025
10 checks passed
@kosabogi kosabogi deleted the cohere-update branch July 15, 2025 09:13
github-actions bot pushed a commit that referenced this pull request Jul 15, 2025
l-trotta pushed a commit that referenced this pull request Aug 1, 2025
(cherry picked from commit a7876a8)

Co-authored-by: kosabogi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants