Skip to content

[8.19] Remove min_compatible_shard_node from async_submit.search #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

pquentin
Copy link
Member

I removed this query parameter from async_search and others in #3108, but did not backport it because the change was 9.x only. And indeed, this parameter is supported in _search. However, it's not supported in async_search.submit, which I tested using start-local:

GET /

{
  "name": "f1d952e5550a",
  "cluster_name": "docker-cluster",
  "cluster_uuid": "c9HcK8cGTrqGew8-_CeGDQ",
  "version": {
    "number": "8.18.3",
    "build_flavor": "default",
    "build_type": "docker",
    "build_hash": "28fc77664903e7de48ba5632e5d8bfeb5e3ed39c",
    "build_date": "2025-06-18T22:08:41.171261054Z",
    "build_snapshot": false,
    "lucene_version": "9.12.1",
    "minimum_wire_compatibility_version": "7.17.0",
    "minimum_index_compatibility_version": "7.0.0"
  },
  "tagline": "You Know, for Search"
}
POST /sales*/_async_search?size=0&min_compatible_shard_node=7.17.20
{
  "sort": [
    { "date": { "order": "asc" } }
  ],
  "aggs": {
    "sale_date": {
      "date_histogram": {
        "field": "date",
        "calendar_interval": "1d"
      }
    }
  }
}

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_argument_exception",
        "reason": "request [/sales*/_async_search] contains unrecognized parameter: [min_compatible_shard_node]"
      }
    ],
    "type": "illegal_argument_exception",
    "reason": "request [/sales*/_async_search] contains unrecognized parameter: [min_compatible_shard_node]"
  },
  "status": 400
}

While it works in _search.

I don't think this worked at any point in async_search.

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 4ff24a7 into 8.19 Jul 21, 2025
8 checks passed
@pquentin pquentin deleted the rest-api-spec-8.19-async-search-submit branch July 21, 2025 11:41
github-actions bot pushed a commit that referenced this pull request Jul 21, 2025
pquentin added a commit that referenced this pull request Jul 21, 2025
…) (#4987)

(cherry picked from commit 4ff24a7)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants