Use strings instead of integer ids for simulate examples #5061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers.
masseyke
approved these changes
Jul 30, 2025
|
The CI fails with |
|
no need to run validation on examples, I'll just merge it |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828)
l-trotta
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828) Co-authored-by: Lee Hinman <[email protected]>
l-trotta
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828) Co-authored-by: Lee Hinman <[email protected]>
l-trotta
pushed a commit
that referenced
this pull request
Jul 31, 2025
* Use strings instead of integer ids for simulate examples These examples were being rendered with the `_id` as an integer, however, that is invalid and we only allow strings for integers. * Change " -> ' because... reasons? (cherry picked from commit 36c4828) Co-authored-by: Lee Hinman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These examples were being rendered with the
_idas an integer, however, that is invalid and we only allow strings for integers.