Remove number_of_shards setting from clone API example
#5073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting is allowed only if the number of shards matches that of the source index, and that's the behaviour anyway, so it is needlessly confusing to include it here.
PeteGillinElastic
changed the title
number_of_shards setting from clone API example
PeteGillinElastic
force-pushed
the
clone-indices-example-remove-number-of-shards
branch
from
d04a890 to
dfc8d73
Compare
PeteGillinElastic
added
the
skip-backport
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
dakrone
reviewed
Aug 4, 2025
| @@ -6,12 +6,6 @@ description: > | |||
| # type: request | |||
| value: "{ | |||
|
|
|||
| \ \"settings\": { | |||
There was a problem hiding this comment.
Since the description says "The API accepts settings and aliases parameters for the target index", can we keep an example of updating the settings here? Perhaps we can use index.refresh_interval instead of the primary shards one?
There was a problem hiding this comment.
Yeah, that's a good idea. Done. (I had considered doing something like this, but I couldn't think of any settings that one would be likely to specify while cloning. I would guess that most clones are "clean" copies, though I could be wrong.)
PeteGillinElastic
deleted the
clone-indices-example-remove-number-of-shards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is allowed only if the number of shards matches that of the source index, and that's the behaviour anyway, so it is needlessly confusing to include it here.