Skip to content

[ML] Remove mention of models in inference actions #107704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 1, 2024

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Apr 22, 2024

This renames the GET, PUT and DELETE inference APIs removing the model parts.

  • inference.delete_model renamed to inference.delete
  • inference.get_model renamed to inference.get
  • inference.put renamed to inference.put

The GET response now has a endpoints field instead of models

#previously
{
    "models": [...]  
}

#with this change
{
    "endpoints": [...]  
}

And error messages are change to refer to inference endpoints rather than models

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't review the Elasticsearch code itself, but left a couple copywriting suggestions.

davidkyle and others added 5 commits April 26, 2024 11:09
…inference/registry/ModelRegistry.java

Co-authored-by: Quentin Pradet <[email protected]>
…inference/registry/ModelRegistryTests.java

Co-authored-by: Quentin Pradet <[email protected]>
…inference/registry/ModelRegistryTests.java

Co-authored-by: Quentin Pradet <[email protected]>
Copy link
Contributor

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

davidkyle and others added 3 commits April 26, 2024 15:46
@davidkyle
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@davidkyle davidkyle merged commit 53252c6 into elastic:main May 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >refactoring Team:ML Meta label for the ML team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants