-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[ML] Remove mention of models in inference actions #107704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/ml-core (Team:ML) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't review the Elasticsearch code itself, but left a couple copywriting suggestions.
rest-api-spec/src/main/resources/rest-api-spec/api/inference.delete.json
Outdated
Show resolved
Hide resolved
...plugin/inference/src/main/java/org/elasticsearch/xpack/inference/registry/ModelRegistry.java
Outdated
Show resolved
Hide resolved
...n/inference/src/test/java/org/elasticsearch/xpack/inference/registry/ModelRegistryTests.java
Outdated
Show resolved
Hide resolved
...n/inference/src/test/java/org/elasticsearch/xpack/inference/registry/ModelRegistryTests.java
Outdated
Show resolved
Hide resolved
…elete.json Co-authored-by: Quentin Pradet <[email protected]>
…inference/registry/ModelRegistry.java Co-authored-by: Quentin Pradet <[email protected]>
…inference/registry/ModelRegistryTests.java Co-authored-by: Quentin Pradet <[email protected]>
…inference/registry/ModelRegistryTests.java Co-authored-by: Quentin Pradet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ore/src/main/java/org/elasticsearch/xpack/core/inference/action/GetInferenceModelAction.java
Outdated
Show resolved
Hide resolved
…inference/action/GetInferenceModelAction.java Co-authored-by: Max Hniebergall <[email protected]>
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
This renames the GET, PUT and DELETE inference APIs removing the
model
parts.inference.delete_model
renamed toinference.delete
inference.get_model
renamed toinference.get
inference.put
renamed toinference.put
The GET response now has a
endpoints
field instead ofmodels
And error messages are change to refer to inference endpoints rather than models