Skip to content

Expose ?master_timeout in autoscaling APIs #108759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2024
Merged

Expose ?master_timeout in autoscaling APIs #108759

merged 4 commits into from
May 21, 2024

Conversation

DaveCTurner
Copy link
Contributor

Relates #107984

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@DaveCTurner DaveCTurner requested a review from idegtiarenko May 20, 2024 15:02
@DaveCTurner
Copy link
Contributor Author

This was fairly mechanical, just adding plumbing to expose the relevant params in the REST layer, but note also the slight change to the wire protocol of GetAutoscalingCapacityAction$Request and the slight change to how a PutAutoscalingPolicyAction$Request is generated by parsing the request body. Still, nothing very controversial here.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 21, 2024
@elasticsearchmachine elasticsearchmachine merged commit 49a253f into elastic:main May 21, 2024
@DaveCTurner DaveCTurner deleted the 2024/05/17/autoscaling-master-node-timeout branch May 21, 2024 08:24
@DaveCTurner DaveCTurner restored the 2024/05/17/autoscaling-master-node-timeout branch June 17, 2024 06:16
@pquentin pquentin mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Distributed Coordination/Autoscaling Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @idegtiarenko