Remove unsupported async_search parameters from rest-api-spec #117626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly reverts commit 2f8bb0b introduced in #117312.
@javanna pointed me to this comment that I had read but failed to fully take into account:
elasticsearch/x-pack/plugin/async-search/src/main/java/org/elasticsearch/xpack/search/RestSubmitAsyncSearchAction.java
Lines 60 to 63 in 2ed318f
And indeed three parameters raise an exception:
elasticsearch/x-pack/plugin/async-search/src/test/java/org/elasticsearch/xpack/search/SubmitAsyncSearchRequestTests.java
Lines 102 to 126 in 2ed318f
However, I kept
ccs_minimize_roundtrips
which is explicitly supported (as stated in the comment too):elasticsearch/x-pack/plugin/async-search/src/test/java/org/elasticsearch/xpack/search/SubmitAsyncSearchRequestTests.java
Lines 84 to 89 in 2ed318f