Skip to content

StressSearchServiceReaperIT_unmute_test #122793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 58 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
9d9b6af
unmute tests
drempapis Jan 3, 2025
02ddf82
revert
drempapis Jan 3, 2025
bf79ef3
Merge remote-tracking branch 'upstream/main'
drempapis Jan 3, 2025
f1c91bd
Merge remote-tracking branch 'upstream/main'
drempapis Jan 7, 2025
ba67bff
Merge remote-tracking branch 'upstream/main'
drempapis Jan 7, 2025
2c3654a
Merge remote-tracking branch 'upstream/main'
drempapis Jan 8, 2025
58d4762
Merge remote-tracking branch 'upstream/main'
drempapis Jan 8, 2025
bc38090
Merge remote-tracking branch 'upstream/main'
drempapis Jan 9, 2025
ef0447b
Merge remote-tracking branch 'upstream/main'
drempapis Jan 9, 2025
fe009d7
Merge remote-tracking branch 'upstream/main'
drempapis Jan 10, 2025
a747a40
Merge remote-tracking branch 'upstream/main'
drempapis Jan 10, 2025
f3e47ae
Merge remote-tracking branch 'upstream/main'
drempapis Jan 10, 2025
2bc0107
Merge remote-tracking branch 'upstream/main'
drempapis Jan 13, 2025
f3b3d00
Merge remote-tracking branch 'upstream/main'
drempapis Jan 13, 2025
f52789e
Merge remote-tracking branch 'upstream/main'
drempapis Jan 14, 2025
ec243b7
Merge remote-tracking branch 'upstream/main'
drempapis Jan 14, 2025
f93eb9b
Merge remote-tracking branch 'upstream/main'
drempapis Jan 16, 2025
2777916
Merge remote-tracking branch 'upstream/main'
drempapis Jan 16, 2025
623bd7b
Merge remote-tracking branch 'upstream/main'
drempapis Jan 16, 2025
3fee6af
Merge remote-tracking branch 'upstream/main'
drempapis Jan 16, 2025
af3fff9
Merge remote-tracking branch 'upstream/main'
drempapis Jan 17, 2025
a41bbad
Merge remote-tracking branch 'upstream/main'
drempapis Jan 17, 2025
8115a61
Merge remote-tracking branch 'upstream/main'
drempapis Jan 20, 2025
6b2361e
Merge remote-tracking branch 'upstream/main'
drempapis Jan 20, 2025
41dcc1c
Merge remote-tracking branch 'upstream/main'
drempapis Jan 21, 2025
2df7f62
Merge remote-tracking branch 'upstream/main'
drempapis Jan 21, 2025
6b95b0c
Merge remote-tracking branch 'upstream/main'
drempapis Jan 22, 2025
eadf8cf
Merge remote-tracking branch 'upstream/main'
drempapis Jan 23, 2025
41dc557
Merge remote-tracking branch 'upstream/main'
drempapis Jan 24, 2025
e0e1740
Merge remote-tracking branch 'upstream/main'
drempapis Jan 24, 2025
1ba2eaa
Merge remote-tracking branch 'upstream/main'
drempapis Jan 24, 2025
6820c35
Merge remote-tracking branch 'upstream/main'
drempapis Jan 24, 2025
8280559
Merge remote-tracking branch 'upstream/main'
drempapis Jan 24, 2025
e82375e
Merge remote-tracking branch 'upstream/main'
drempapis Jan 27, 2025
ce4c1c9
Merge remote-tracking branch 'upstream/main'
drempapis Jan 27, 2025
ff92f92
Merge remote-tracking branch 'upstream/main'
drempapis Jan 28, 2025
c0f4d18
Merge remote-tracking branch 'upstream/main'
drempapis Jan 28, 2025
02ac377
Merge remote-tracking branch 'upstream/main'
drempapis Jan 29, 2025
42aa647
Merge remote-tracking branch 'upstream/main'
drempapis Jan 30, 2025
bd258ab
Merge remote-tracking branch 'upstream/main'
drempapis Jan 30, 2025
0d5b0d3
Merge remote-tracking branch 'upstream/main'
drempapis Jan 31, 2025
a6f543a
Merge remote-tracking branch 'upstream/main'
drempapis Jan 31, 2025
89a6aca
Merge remote-tracking branch 'upstream/main'
drempapis Jan 31, 2025
19b0900
Merge remote-tracking branch 'upstream/main'
drempapis Jan 31, 2025
9f1af25
Merge remote-tracking branch 'upstream/main'
drempapis Feb 3, 2025
9cedf78
Merge remote-tracking branch 'upstream/main'
drempapis Feb 7, 2025
a23541b
Merge remote-tracking branch 'upstream/main'
drempapis Feb 11, 2025
406af11
Merge remote-tracking branch 'upstream/main'
drempapis Feb 14, 2025
d324d5f
Merge remote-tracking branch 'upstream/main'
drempapis Feb 14, 2025
fc2b041
Merge remote-tracking branch 'upstream/main'
drempapis Feb 14, 2025
206454b
Merge remote-tracking branch 'upstream/main'
drempapis Feb 14, 2025
f36ed2a
Merge remote-tracking branch 'upstream/main'
drempapis Feb 17, 2025
acc28b5
Merge remote-tracking branch 'upstream/main'
drempapis Feb 17, 2025
f8d3ce0
Merge remote-tracking branch 'upstream/main'
drempapis Feb 17, 2025
c34cc87
Merge remote-tracking branch 'upstream/main'
drempapis Feb 17, 2025
e2c36f8
Merge remote-tracking branch 'upstream/main'
drempapis Feb 17, 2025
aaf815a
update code
drempapis Feb 17, 2025
9f1f662
[CI] Auto commit changes from spotless
Feb 17, 2025
9c31574
revert code
drempapis Feb 19, 2025
9214aab
revert imports
drempapis Feb 19, 2025
0356635
Merge branch 'main' into fix/StressSearchServiceReaperIT_unmute_test
drempapis Feb 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ tests:
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
method: test {p0=transform/transforms_start_stop/Verify start transform reuses destination index}
issue: https://github.com/elastic/elasticsearch/issues/115808
- class: org.elasticsearch.search.StressSearchServiceReaperIT
method: testStressReaper
issue: https://github.com/elastic/elasticsearch/issues/115816
- class: org.elasticsearch.xpack.application.connector.ConnectorIndexServiceTests
issue: https://github.com/elastic/elasticsearch/issues/116087
- class: org.elasticsearch.xpack.test.rest.XPackRestIT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

import org.apache.lucene.tests.util.English;
import org.elasticsearch.action.index.IndexRequestBuilder;
import org.elasticsearch.action.search.SearchRequestBuilder;
import org.elasticsearch.action.search.SearchResponse;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.test.ESIntegTestCase;
Expand All @@ -33,7 +35,6 @@ protected Settings nodeSettings(int nodeOrdinal, Settings otherSettings) {
.build();
}

// see issue #5165 - this test fails each time without the fix in pull #5170
public void testStressReaper() throws ExecutionException, InterruptedException {
int num = randomIntBetween(100, 150);
IndexRequestBuilder[] builders = new IndexRequestBuilder[num];
Expand All @@ -44,7 +45,16 @@ public void testStressReaper() throws ExecutionException, InterruptedException {
indexRandom(true, builders);
final int iterations = scaledRandomIntBetween(500, 1000);
for (int i = 0; i < iterations; i++) {
assertHitCountAndNoFailures(prepareSearch("test").setQuery(matchAllQuery()).setSize(num), num);
SearchResponse response = null;
try {
SearchRequestBuilder searchRequestBuilder = prepareSearch("test").setQuery(matchAllQuery()).setSize(num);
response = searchRequestBuilder.get();
assertHitCountAndNoFailures(searchRequestBuilder, num);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sorry this can't be it. The builder is resolved and the response released right away by assertHitCountAndNoFailures. If we're leaking it's not because we're leaking the actual search response, we're leaking some intermediary objects and likely never get to the search response here.

See this line in the failure:

	org.elasticsearch.action.search.ArraySearchPhaseResults.<init>(ArraySearchPhaseResults.java:28)

we're leaking the intermediary per-shard response array, we're not leaking a fully built response.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @original-brownbear, for the feedback. After a private discussion, we decided it was safe to unmute the test.

} finally {
if (response != null) {
response.decRef();
}
}
}
}
}