-
Notifications
You must be signed in to change notification settings - Fork 25.3k
StressSearchServiceReaperIT_unmute_test #122793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drempapis
merged 61 commits into
elastic:main
from
drempapis:fix/StressSearchServiceReaperIT_unmute_test
Feb 19, 2025
Merged
Changes from 58 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
9d9b6af
unmute tests
drempapis 02ddf82
revert
drempapis bf79ef3
Merge remote-tracking branch 'upstream/main'
drempapis f1c91bd
Merge remote-tracking branch 'upstream/main'
drempapis ba67bff
Merge remote-tracking branch 'upstream/main'
drempapis 2c3654a
Merge remote-tracking branch 'upstream/main'
drempapis 58d4762
Merge remote-tracking branch 'upstream/main'
drempapis bc38090
Merge remote-tracking branch 'upstream/main'
drempapis ef0447b
Merge remote-tracking branch 'upstream/main'
drempapis fe009d7
Merge remote-tracking branch 'upstream/main'
drempapis a747a40
Merge remote-tracking branch 'upstream/main'
drempapis f3e47ae
Merge remote-tracking branch 'upstream/main'
drempapis 2bc0107
Merge remote-tracking branch 'upstream/main'
drempapis f3b3d00
Merge remote-tracking branch 'upstream/main'
drempapis f52789e
Merge remote-tracking branch 'upstream/main'
drempapis ec243b7
Merge remote-tracking branch 'upstream/main'
drempapis f93eb9b
Merge remote-tracking branch 'upstream/main'
drempapis 2777916
Merge remote-tracking branch 'upstream/main'
drempapis 623bd7b
Merge remote-tracking branch 'upstream/main'
drempapis 3fee6af
Merge remote-tracking branch 'upstream/main'
drempapis af3fff9
Merge remote-tracking branch 'upstream/main'
drempapis a41bbad
Merge remote-tracking branch 'upstream/main'
drempapis 8115a61
Merge remote-tracking branch 'upstream/main'
drempapis 6b2361e
Merge remote-tracking branch 'upstream/main'
drempapis 41dcc1c
Merge remote-tracking branch 'upstream/main'
drempapis 2df7f62
Merge remote-tracking branch 'upstream/main'
drempapis 6b95b0c
Merge remote-tracking branch 'upstream/main'
drempapis eadf8cf
Merge remote-tracking branch 'upstream/main'
drempapis 41dc557
Merge remote-tracking branch 'upstream/main'
drempapis e0e1740
Merge remote-tracking branch 'upstream/main'
drempapis 1ba2eaa
Merge remote-tracking branch 'upstream/main'
drempapis 6820c35
Merge remote-tracking branch 'upstream/main'
drempapis 8280559
Merge remote-tracking branch 'upstream/main'
drempapis e82375e
Merge remote-tracking branch 'upstream/main'
drempapis ce4c1c9
Merge remote-tracking branch 'upstream/main'
drempapis ff92f92
Merge remote-tracking branch 'upstream/main'
drempapis c0f4d18
Merge remote-tracking branch 'upstream/main'
drempapis 02ac377
Merge remote-tracking branch 'upstream/main'
drempapis 42aa647
Merge remote-tracking branch 'upstream/main'
drempapis bd258ab
Merge remote-tracking branch 'upstream/main'
drempapis 0d5b0d3
Merge remote-tracking branch 'upstream/main'
drempapis a6f543a
Merge remote-tracking branch 'upstream/main'
drempapis 89a6aca
Merge remote-tracking branch 'upstream/main'
drempapis 19b0900
Merge remote-tracking branch 'upstream/main'
drempapis 9f1af25
Merge remote-tracking branch 'upstream/main'
drempapis 9cedf78
Merge remote-tracking branch 'upstream/main'
drempapis a23541b
Merge remote-tracking branch 'upstream/main'
drempapis 406af11
Merge remote-tracking branch 'upstream/main'
drempapis d324d5f
Merge remote-tracking branch 'upstream/main'
drempapis fc2b041
Merge remote-tracking branch 'upstream/main'
drempapis 206454b
Merge remote-tracking branch 'upstream/main'
drempapis f36ed2a
Merge remote-tracking branch 'upstream/main'
drempapis acc28b5
Merge remote-tracking branch 'upstream/main'
drempapis f8d3ce0
Merge remote-tracking branch 'upstream/main'
drempapis c34cc87
Merge remote-tracking branch 'upstream/main'
drempapis e2c36f8
Merge remote-tracking branch 'upstream/main'
drempapis aaf815a
update code
drempapis 9f1f662
[CI] Auto commit changes from spotless
9c31574
revert code
drempapis 9214aab
revert imports
drempapis 0356635
Merge branch 'main' into fix/StressSearchServiceReaperIT_unmute_test
drempapis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sorry this can't be it. The builder is resolved and the response released right away by
assertHitCountAndNoFailures
. If we're leaking it's not because we're leaking the actual search response, we're leaking some intermediary objects and likely never get to the search response here.See this line in the failure:
we're leaking the intermediary per-shard response array, we're not leaking a fully built response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @original-brownbear, for the feedback. After a private discussion, we decided it was safe to unmute the test.