[TEST] Remove YAML Tests #131434
Merged
[TEST] Remove YAML Tests #131434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-adams-1
added
>non-issue
:Distributed Coordination/Network
Removes YAML tests for the `/_cluster/allocation/explain` API. The tests passed in alternate values for the APIs. An example is passing "true" for fields expecting a boolean value. While this is explicitly supported by the API, this is not the correct place to be testing this behaviour, and resulted in the API specification failing validation. Relates elastic#127028
joshua-adams-1
force-pushed
the
remove-yaml-tests
branch
from
7b77737 to
7c24339
Compare
pquentin
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes YAML tests for the
/_cluster/allocation/explainAPI. The tests passed in alternate, but still supported, values for the APIs. An example is passing "true" for fields expecting a boolean value. While this is explicitly supported by the API, this is not the correct place to be testing this behaviour, and resulted in the API specification failing validation.See a related PR on the
elasticsearch-specificationrepo, elastic/elasticsearch-specification#4939, where I attempted to update the API spec for the/_cluster/allocation/explainAPI based on previous changes in #129342, and the inclusion of the YAML tests was failing the validation.Relates #127028