feat(eui): add noItemsMessage prop to EuiInMemoryTable #8812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
added
support-duty-flywheel
weronikaolejniczak
force-pushed
the
chore/add-message-prop-jsdoc
branch
from
b0a51e2 to
2f2f0eb
Compare
weronikaolejniczak
force-pushed
the
chore/add-message-prop-jsdoc
branch
from
2f2f0eb to
9a8baa9
Compare
38 tasks
weronikaolejniczak
force-pushed
the
chore/add-message-prop-jsdoc
branch
from
175f56c to
0c91584
Compare
acstll
approved these changes
Jun 30, 2025
acstll
requested changes
Jun 30, 2025
There was a problem hiding this comment.
I think it'd make sense to add an entry in the changelog, since it's a prop being renamed; what do you think @weronikaolejniczak? 🤔
|
I agree, we'd need a changelog entry for such a change to inform users about the deprecation. Other than that, the changes look solid. Thank you! |
|
@acstll ahhh, you're totally right! So at first all I did was add a JSDoc comment, and that's why I added |
weronikaolejniczak
removed
the
skip-changelog
weronikaolejniczak
force-pushed
the
chore/add-message-prop-jsdoc
branch
from
0c91584 to
a3d6da8
Compare
weronikaolejniczak
force-pushed
the
chore/add-message-prop-jsdoc
branch
from
a3d6da8 to
2b03732
Compare
weronikaolejniczak
changed the title
acstll
approved these changes
Jun 30, 2025
💚 Build SucceededHistory
|
💚 Build Succeeded
History
|
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Jul 2, 2025
`104.0.2` ⏩ `104.1.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Package updates ### `@elastic/eui` #### [`v104.1.0`](https://github.com/elastic/eui/releases/v104.1.0) - Added new component token `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813)) - Updated background color for `EuiCode` to use `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813)) - Added `noItemsMessage` prop to `EuiInMemoryTable` ([#8812](elastic/eui#8812)) - Added prop `delimiter` on `EuiDatePickerRange` ([#8810](elastic/eui#8810)) **Bug fixes** - Fixed an issue with `EuiSuperDatePicker` where toggling `isQuickSelectOnly` would cause a full re-render when the selected range uses absolute dates ([#8810](elastic/eui#8810)) **Deprecations** - Deprecated `message` prop in `EuiInMemoryTable` in favor of `noItemsMessage` which is a more meaningful prop name; there are no functional changes ([#8812](elastic/eui#8812)) ### `@elastic/eui-theme-borealis` #### [`v3.1.0`](https://github.com/elastic/eui/releases/v3.1.0) - Added new component token `components.forms.codeInlineBackground` ([#8813](elastic/eui#8813))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
messageprop inEuiInMemoryTabledoesn't have a JSDoc comment so developers may not immediately know its purpose. It is passed to thenoItemsMessagewhich is a more explicit name.(source: EuiInMemoryTable > message)
What I'm doing here is adding
noItemsMessage(that's passed intonoItemsMessageinEuiBasicTable) and markmessageas deprecated.Impact to users
It's not a breaking change. It helps developers understand the purpose of the
messageprop better by just reading the prop namenoItemsMessage, and show the description on the documentation site.Added to the Deprecation Schedule.
QA
messageprop on EuiInMemoryTable pagenoItemsMessageprop shows up with an appropriate message on the same page