[tests] ensure that the notifier is emptied by each test #8822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Bargs
reviewed
Oct 25, 2016
| beforeEach(function () { | ||
| if (Notifier.prototype._notifs.length) { | ||
| Notifier.prototype._notifs.length = 0; | ||
| throw new TypeError('notifications were left in the notifier'); |
There was a problem hiding this comment.
This doesn't seem like a TypeError to me
elastic-jasper
added a commit
that referenced
this pull request
Oct 25, 2016
--------- **Commit 1:** [tests] ensure that the notifier is emptied by each test * Original sha: 0cdef8c * Authored by spalger <[email protected]> on 2016-10-25T00:09:57Z **Commit 2:** [testHarness] use generic Error class * Original sha: 34659fb * Authored by spalger <[email protected]> on 2016-10-25T22:11:39Z
spalger
added a commit
that referenced
this pull request
Oct 25, 2016
[backport] PR #8822 to 5.x - [tests] ensure that the notifier is emptied by each test
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [tests] ensure that the notifier is emptied by each test * Original sha: 11e9af0d765960bcf586bbebe2d9309b1506d264 [formerly 0cdef8c] * Authored by spalger <[email protected]> on 2016-10-25T00:09:57Z **Commit 2:** [testHarness] use generic Error class * Original sha: d7e994e720ebdb6a2c0cd499936956ad1fe1fbee [formerly 34659fb] * Authored by spalger <[email protected]> on 2016-10-25T22:11:39Z Former-commit-id: cfb469b
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8822 to 5.x - [tests] ensure that the notifier is emptied by each test Former-commit-id: 9e7afe5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8734 I noticed that:
This fixes these issues by checking before each test run that notifications were properly cleared out after the last test.