-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Expanding ${arch} macro properly for mac.binaries in case of native node packages #9263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 5cd812f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You can test it with: |
|
This looks solid! Thank you for the contribution! Quick request. Can you please run the command |
|
Hey @mmaietta, prettier issues are fixed 👍 |
|
Just realized that a File: Content: |
|
@mmaietta Changeset added. |
We have this issue where we pack
realm.nodethat needs signing.Our CI either builds universal or arm64 + x64 archs.
It was not possible to say which file to sign in
mac.binaries, as it is underapp.asar.unpackedorapp-x64.asar.unpackedand then for universal arch it should double the paths as we need to sign bothapp-arm64.asar.unpackedandapp-x64.asar.unpackedThis fixes the issue, we have tested with:
and
with configuration
