Skip to content

Conversation

@bimusiek
Copy link
Contributor

We have this issue where we pack realm.node that needs signing.
Our CI either builds universal or arm64 + x64 archs.

It was not possible to say which file to sign in mac.binaries, as it is under app.asar.unpacked or app-x64.asar.unpacked and then for universal arch it should double the paths as we need to sign both app-arm64.asar.unpacked and app-x64.asar.unpacked

This fixes the issue, we have tested with:

electron-builder --mac zip:universal --universal --publish always --config electron/electron-fym.yml

and

electron-builder -lm --publish always --config electron/electron-fym.yml

with configuration
CleanShot 2025-08-29 at 12 22 04@2x

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025

🦋 Changeset detected

Latest commit: 5cd812f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bimusiek bimusiek changed the title Expanding ${arch} macro properly for mac.binaries in case of native node packages feat: Expanding ${arch} macro properly for mac.binaries in case of native node packages Aug 29, 2025
@bimusiek
Copy link
Contributor Author

bimusiek commented Sep 1, 2025

You can test it with:

    "@hernas/electron-builder": "26.0.29",
    "@hernas/app-builder-lib": "26.0.29",

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 1, 2025

This looks solid! Thank you for the contribution!

Quick request. Can you please run the command pnpm prettier when you have a chance? A ton of linter warnings are in the PR. Other than that, this LGTM

@bimusiek
Copy link
Contributor Author

bimusiek commented Sep 2, 2025

Hey @mmaietta, prettier issues are fixed 👍

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 5, 2025

Just realized that a changeset is missing. Can you please add this file? Either via pnpm generate-changeset or just copy pasting the content below

File:
.changeset/eighty-snails-dress.md (or any random name within that folder)

Content:

---
"app-builder-lib": patch
---

feat: Expanding `${arch}` macro properly for `mac.binaries` in case of native node packages for unpacked files for macos `universal` target

@bimusiek
Copy link
Contributor Author

bimusiek commented Sep 8, 2025

@mmaietta Changeset added.

@mmaietta mmaietta merged commit 08773af into electron-userland:master Sep 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants