Update icons from Figma. #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither Kotlin nor Swift were being updated. But the fix was in getIOSConfig 🤷♂️
Member
That's not scary at all 🫠 . |
Member
|
Uh oh. We could make our CI wipe the |
jmartinesp
approved these changes
Jul 24, 2024
Member
jmartinesp
left a comment
jmartinesp
left a comment
There was a problem hiding this comment.
All the icons were imported fine in Compound Android locally, LGTM!
Member
Author
Yeah sounds reasonable to me. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Velin92 noticed that the
unpinicon was missing, so I decided to do a complete sync with Figma. This has resulted incalendarandroomalso being added and a handful of seemingly minor tweaks to existing icons - the export was done with the usualMonochromepreset and only about 30% of the icons have changes so may just be refinements to the path algorithm in the plugin.The second commit tweaks the generation script as (possibly following the style dictionary update?) we weren't generating the icons for Swift or Kotlin. I have zero idea why editing
getIOSConfigfixed Kotlin, but it did 🤷♂️.